Add support for x386 debian 11/12, amd64 debian 11/12, arm64 debian9/10/11/12 with test

zakird / wkhtmltopdf_binary_gem

Ruby gem containing easily installable access to wkhtmltopdf application

https://rubygems.org/gems/wkhtmltopdf-binary

Apache License 2.0

183 stars 347 forks source link

Add support for x386 debian 11/12, amd64 debian 11/12, arm64 debian9/10/11/12 with test #145

Closed willnet closed 5 months ago

willnet commented 2 years ago

Added binaries for x386 debian 11/12, amd64 debian 11/12, arm64 debian9/10/11/12 and made them available for testing on GitHub Actions
- Since we can't select arm64 platform in GitHub Actions on github.com, use docker/setup-qemu-action to virtually realize testing on arm64.
- It was difficult to use the same docker-compose.yml and Dockerfile for x86 and arm64, so create docker-compose.yml and Dockerfile for arm64 version.
Since we are using docker to test on x86 ubuntu, we don't need multiple versions of Ruby on ubuntu, so we only use one version of Ruby.
Fixed a bug that the order of arguments of assert_equal method was reversed.
Loosened conditions for passing the test
- Only 0.12.6.1 binaries are available under newer distributions such as debian11, so make the tests pass.
Add Ruby 3.2 to CI matrix
Fix a broken archlinux test
- Fix an error that the libssl library could not be found
update github actions

LeEnno commented 1 year ago

This would close #121, #122 and #146.

I added the line…

gem 'wkhtmltopdf-binary', git: 'https://github.com/willnet/wkhtmltopdf_binary_gem.git', branch: 'arm'

…to my Gemfile and it works as expected with Docker (ruby:2.6.6-buster) on my Apple Silicon Mac. No more hacks necessary.

If you have a minute – @pedrofurtado and @unixmonkey – I would greatly appreciate your attention on this PR.

willnet commented 1 year ago

Add binaries for debian11.

willnet commented 1 year ago

~~a test failure about archlinux is resolved by #156~~

jeffbax commented 1 year ago

Would love to see this one get merged into the main repo!

slayer commented 1 year ago

Hey guys,

any news here?

mikekosulin commented 1 year ago

willnet commented 11 months ago

I have added debian12 binaries.

Now debian9 fails to build, does anyone know a good solution for this?

mikekosulin commented 11 months ago

I have added debian12 binaries.

Now debian9 fails to build, does anyone know a good solution for this?

Issue is due to End of Life (EOL). Please check out my PR

matthiaz commented 11 months ago

I made a new repo and merged the MR from @willnet https://github.com/matthiaz/wkhtmltopdf_binary_gem

I then pushed a new gem: https://rubygems.org/gems/wkhtmltopdf-binary-ng/versions/0.12.6.6 so it can be used by others

So in stead of using gem install wkhtmltopdf-binary you could use gem install wkhtmltopdf-binary-ng and roll with that.

Apart from this MR, nothing else was changed in the gem. But we could, if this repo stays stale...

bernica commented 10 months ago

@zakird @pedrofurtado @unixmonkey is any of you maintaining this repo? Any thoughts or decision on this?

unixmonkey commented 5 months ago

Thank you! These contributions are now in version 0.12.6.7. Please check it and make sure it still works for you. I really appreciate you taking the time to fix the CI issues, and bringing over a bunch of the arm64 binaries.