search

zakird / wkhtmltopdf_binary_gem

Ruby gem containing easily installable access to wkhtmltopdf application
https://rubygems.org/gems/wkhtmltopdf-binary
Apache License 2.0
184 stars 346 forks source link

Version 0.12.5 #45

Closed map7 closed 5 years ago

map7 commented 6 years ago

Here is the new version I found in another fork, maybe this should be merged into the main gem?

bary822 commented 6 years ago

@unixmonkey Any chances merging this, if the conflict is resolved?

unixmonkey commented 6 years ago

@map7 @bary822 The conflict is likely because it this PR was created before I merged #40, a rebase should take care of that minor issue.

This PR is still missing an updated linux_x86 binary. Once that is added and confirmed working, I'll gladly merge and cut a new release.

saurabh-prohaktiv commented 6 years ago

@map7, @unixmonkey just FYI, this fork contains the binaries for 0.12.5-rc and not 0.12.5 (I don't think that there is any difference between the two but I am not sure), also after 0.12.5 got released, I saw that it has various builds for various OS as you can see here and are not just generic builds for linux and mac as they were before.

tenji240 commented 6 years ago

Hi, have there been any updates to this PR?

map7 commented 6 years ago

No there hasn't been, I'm using the wkhtmltopdf binary in my ansible scripts instead of this now.

On Sun, Aug 5, 2018 at 5:18 AM, Tenji Tembo notifications@github.com wrote:

Hi, have there been any updates to this PR?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

t-richard commented 6 years ago

Hello, is there any news on this PR ? Is a new PR going to be created as said in #46 ?

pedrofurtado commented 5 years ago

@zakird @unixmonkey Any news? 👍

pedrofurtado commented 5 years ago

@unixmonkey I think this PR should be closed :+1: the binary version is already updated :+1: