search

zakird / wkhtmltopdf_binary_gem

Ruby gem containing easily installable access to wkhtmltopdf application
https://rubygems.org/gems/wkhtmltopdf-binary
Apache License 2.0
184 stars 346 forks source link

Add support for Linux Mint 19.2 #56

Closed alextakitani closed 4 years ago

alextakitani commented 5 years ago

Created a link for Linux Mint 19.2 pointing to Ubuntu 18.04 binaries.

The same would work for other Ubuntu derivatives.

hlascelles commented 5 years ago

Ditto for 19/19.1. Shall I commit to this branch?

wkhtmltopdf_linuxmint_19_amd64.gz => same wkhtmltopdf_linuxmint_19.1_amd64.gz => same

hlascelles commented 5 years ago

And maybe more generally, a config for this gem to allow a pointer to a known compatible version (with a friendly request to open a PR like this)? Work for another PR certainly.

unixmonkey commented 4 years ago

Thank you for this, but I'd much prefer changing the binstub to reference the correct source binary instead of a symlink if that's possible. Will that work for you?

unixmonkey commented 4 years ago

I've gone ahead and rolled this into the binstub as you can see here, so I'm going to close this PR, since it shouldn't be necessary any longer.

Please test this and make sure it works for you, if not, please reopen this and we will get it figured out.

Thank you for your help. 😃

unixmonkey commented 4 years ago

Forgot to mention, the new release that includes this is version 0.12.5.2.