search

zakjan / mapbox-gl-draw-geodesic

Geodesic plugin for Mapbox GL Draw
https://zakjan.github.io/mapbox-gl-draw-geodesic/
MIT License
51 stars 8 forks source link

Upgrading mapbox-gl-draw version from 1.3 to 1.4 #24

Closed aninikol closed 11 months ago

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mapbox-gl-draw-geodesic ❌ Failed (Inspect) Jul 26, 2023 7:57am
zakjan commented 1 year ago

I'm afraid that the upgrade is more complex.

Please make sure that npm run dev build doesn't throw any errors and demo in docs directory works with the updated mapbox-gl-draw as well.

Finally, try to limit the PR changes to minimum as possible, no irrelevant changes, please.

brandonmcconnell commented 1 year ago

@aninikol Are you still actively working on this? I could also greatly benefit from this upgrade. 🙂

brandonmcconnell commented 1 year ago

@aninikol @zakjan What else is left to complete and merge this? I could really benefit from this package in my current ESM project? Does this also support TS types?

zakjan commented 1 year ago

@aninikol Tests in create_geodesic_geojson.test.js still fail, because it relies on internal sources. I have found no other way then copying feature_types directory to this package.

@aninikol @brandonmcconnell @jules-w2 @jaybo Could you try 2.3.0-alpha.0 that I have just published? The expected result is that it should work with mapbox-gl-draw 1.4. The difference from the previous 2.2.3 is that mapbox-gl-draw 1.3 sources are no longer bundled in.

zakjan commented 11 months ago

Done in 2.3.0.