Negative numbers allowed on non-negative values

zakkak / turnin

turnin is a utility that enables students to turnin assignments using the command line. Requires a setup where each class has a unix account in the computer infrastructure of the school/university.

GNU General Public License v3.0

15 stars 8 forks source link

Negative numbers allowed on non-negative values #6

Closed daknob closed 10 years ago

daknob commented 10 years ago

In the LIMITS file, a user is allowed to enter negative values in the fields maxfiles, maxkbytes, maxturnins, binary.

zakkak commented 10 years ago

This would result in an effective value of zero?

daknob commented 10 years ago

No, if the maximum amount of files is -5, you can never turn in, even without files.

On 2 Σεπ 2014, at 16:58, Foivos notifications@github.com wrote:

This would result in an effective value of zero?

— Reply to this email directly or view it on GitHub.

daknob commented 10 years ago

Fix by commit 94dedb4 cannot be verified although it should probably work. I recommend adding proper messaging to follow the other similar errors as well like "Mention to instructor or TAs".