search

zakki / cgos

Computer Go Server mirror
10 stars 4 forks source link

Fix move bug. #7

Closed CGLemon closed 1 year ago

CGLemon commented 1 year ago

Some GTP moves may be upper case. For example, GNU Go uses the PASS.

zakki commented 1 year ago

Original tcl client and server can handle PASS, pass, pAsS because tcl server is case insensitive. I think this behaviour is specification.

If PASS causes propbelm, please send PRs to fix that part instead of this patch

CGLemon commented 1 year ago

Sorry, I should show more details.

This bug was imported from this branch. The original develop branch uses the lower case.

https://github.com/zakki/cgos/blob/c7a3dfca343eb9d9369bda539361baed5dfbc035/client-python/src/cgosclient.py#L378

The client assumes the move is lower case and can only handle lower case move string. I think lower case only would be simply and bug-free.

zakki commented 1 year ago

I was misunderstanding that your patch was meant to fix a problem with the server. I think it is reasonable that the Python client handles lower case.