zakodium-oss / react-plot

Library of React components to render SVG 2D plots. You can check the story book https://react-plot.pages.dev/ or have a look to the extensive documentation
https://react-plot.zakodium.com
MIT License
12 stars 6 forks source link

Disabled hooks #421

Closed wadjih-bencheikh18 closed 2 years ago

wadjih-bencheikh18 commented 2 years ago

closes : https://github.com/zakodium-oss/react-plot/issues/417

netlify[bot] commented 2 years ago

Deploy Preview for react-plot ready!

Name Link
Latest commit ad5a3a5437365fb54d91980f230fd456fb03b9b4
Latest deploy log https://app.netlify.com/sites/react-plot/deploys/62b433c1803dd9000871ca49
Deploy Preview https://deploy-preview-421--react-plot.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

wadjih-bencheikh18 commented 2 years ago

@targos i added disabled param in hooks stories https://deploy-preview-421--react-plot.netlify.app/?path=/story/examples-draw--draw-path https://deploy-preview-421--react-plot.netlify.app/?path=/story/examples-lasso-selection--lasso-selection https://deploy-preview-421--react-plot.netlify.app/?path=/story/examples-spectrum-2d--spectrum-2-d https://deploy-preview-421--react-plot.netlify.app/?path=/story/examples-zoom--horizontal-zoom https://deploy-preview-421--react-plot.netlify.app/?path=/story/experimental-spectra-infrared--infrared-example https://deploy-preview-421--react-plot.netlify.app/?path=/story/experimental-spectra-mass--advanced-mass-example

targos commented 2 years ago

why do you open/close many PRs for the same change?

wadjih-bencheikh18 commented 2 years ago

why do you open/close many PRs for the same change?

I closed the issue because of bad commit message (I used break changes option and it's not the case here), sorry for that

targos commented 2 years ago

Ah, for next time you can use git push --force to update the PR without the need to create a new branch and PR.