zakodium-oss / react-science

React components and tools to build scientific applications.
https://react-science.pages.dev
MIT License
3 stars 6 forks source link

Question: is "uv" just "uv" or all of these? #214

Closed ghost closed 1 year ago

ghost commented 1 year ago

Hi,

Here is the line that I am confused with.

Would the standard "uv-vis" and "uv-vis-nir" measurements belong to the key "uv" as well? Otherwise the only key left for those is "other".

At the moment, in the local updated version I have, the folder dropping is displaying -at least some- spc files. Apart from a few issues problems with xyxy spectra.

Here some Images. (I am not sure why "IV" Tab is being added, as there is no current v voltage curve being added.)

lpatiny commented 1 year ago

Currently it is an open question and @santimirandarp you are probable more aware of those analysis than me.

The idea behind grouping the categories under the same tab is that the same tools would apply to them.

For example IR you would like to see transmittance or absorbance. UV you would like peak picking, etc.

So if you think that the tools related with the specific kind of measurements will be different it should be a new category and therefore a new tab.

Don't hesitate to paste directly images in the issue. If you make a screen snapshot to the clipboard you can paste it directly in the issue.

There is a bug somewhere concerning IV because it should be there.

ghost commented 1 year ago

For example, spc format, defines several types of spectra / chromatogram

   1. 'Gas Chromatogram';
   2. 'General Chromatogram (same as SPCGEN with TCGRAM)';
   3. 'HPLC Chromatogram';
   4. 'NIR Spectrum (Usually multi-spectral data sets for calibration.)';
   5. 'FT-IR, FT-NIR, FT-Raman Spectrum or Igram (Can also be used for scanning IR.)';   
   6. 'UV-VIS Spectrum (Can be used for single scanning UV-VIS-NIR.)';
   7. 'X-ray Diffraction Spectrum';
   8. 'Mass Spectrum  (Can be single, GC-MS, Continuum, Centroid or TOF.)'
   9. 'NMR Spectrum or FID';
   10.  'Raman Spectrum (Usually Diode Array, CCD, etc. use SPCFTIR for FT-Raman.)';
   11. 'Fluorescence Spectrum';
   12. 'Atomic Spectrum';
   13. 'Chromatography Diode Array Spectra';
   14. 'General SPC (could be anything)';

But from a "current-tools" and "current-parsers" point of view, could be collapsed.

Following number 6 I'd do uv/uv-vis/uv-vis-nir as one type ("uv"). Maybe adding atomic absorption because the tools would be the same.

And any type of only-ir under "ir" (collapsing 4 and 5 maybe?), mass under "mass" etc.

And whichever there aren't special tools just yet, under "other".

WDYT @lpatiny? I will send the spc anyways, but maybe this can be updated.