zakodium-oss / react-science

React components and tools to build scientific applications.
https://react-science.pages.dev
MIT License
3 stars 6 forks source link

Replace Tabs component #573

Closed stropitek closed 10 months ago

stropitek commented 1 year ago

Replace usage with blueprintjs https://blueprintjs.com/docs/#core/components/tabs

I think in this case we can remove the stories.

CleanShot 2023-10-18 at 11 55 04

to become

CleanShot 2023-10-18 at 12 01 08

Since there is built-in support for "tags", we can use that to show the number of spectra loaded for each type.

stropitek commented 11 months ago

To check:

targos commented 11 months ago

There's only one use of the Tabs component from here in NMRium. All the others still use the old internal implementation.

stropitek commented 11 months ago

There's only one use of the Tabs component from here in NMRium. All the others still use the old internal implementation.

👍🏻 we are free to just use the blueprintjs components then if they match all our needs