search

zakodium-oss / react-science

React components and tools to build scientific applications.
https://react-science.pages.dev
MIT License
3 stars 6 forks source link

Refactor select using blueprintjs #588

Closed wadjih-bencheikh18 closed 11 months ago

wadjih-bencheikh18 commented 11 months ago

closes #578

cloudflare-workers-and-pages[bot] commented 11 months ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 462ca25
Status: ✅  Deploy successful!
Preview URL: https://7e577c0e.react-science.pages.dev
Branch Preview URL: https://578-replace-select-component.react-science.pages.dev

View logs

codecov-commenter commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (707c929) 46.80% compared to head (ec9b15d) 46.84%. Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #588 +/- ## ========================================== + Coverage 46.80% 46.84% +0.03% ========================================== Files 149 144 -5 Lines 7950 7367 -583 Branches 146 146 ========================================== - Hits 3721 3451 -270 + Misses 4229 3916 -313 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wadjih-bencheikh18 commented 11 months ago

The font size in the list seems to be different when we are in a modal vs otherwise.

The storybook div have style font-size:12px and in the default case the Select popup use portal out of the storybook div image So the font is 14px

In the InModal Story I didn't use the default Portal because the popup must be in the dialog otherwise it's blured, so I used the modal portal from the rootLayoutContext which make it inside the storybook div