search

zakodium-oss / react-science

React components and tools to build scientific applications.
https://react-science.pages.dev
MIT License
3 stars 6 forks source link

fix: make Modal's onRequestClose mandatory and call it on close #602

Closed targos closed 10 months ago

targos commented 10 months ago

BREAKING-CHANGE: Modal's and ConfirmModal's onRequestClose is now mandatory. Note that a Modal has to always be closed (isOpen must be set to false) when onRequestClose is called. This is driven by a change in the HTML spec that ensures a web page cannot indefinitely keep a dialog open. See https://github.com/whatwg/html/pull/9462 and https://bugs.chromium.org/p/chromium/issues/detail?id=1511166#c1

cloudflare-workers-and-pages[bot] commented 10 months ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: db25587
Status: ✅  Deploy successful!
Preview URL: https://3f4c9652.react-science.pages.dev
Branch Preview URL: https://fix-modal.react-science.pages.dev

View logs

codecov-commenter commented 10 months ago

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (63f093b) 24.49% compared to head (db25587) 24.50%.

Files Patch % Lines
src/components/modal/useDialog.ts 30.00% 7 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #602 +/- ## ======================================= Coverage 24.49% 24.50% ======================================= Files 223 223 Lines 12954 12954 Branches 234 234 ======================================= + Hits 3173 3174 +1 + Misses 9693 9692 -1 Partials 88 88 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.