Use 14px as base font size

zakodium-oss / react-science

React components and tools to build scientific applications.

https://react-science.pages.dev

MIT License

3 stars 6 forks source link

Use 14px as base font size #607

Closed stropitek closed 8 months ago

stropitek commented 10 months ago

Let's make this change so that our base font is compatible with blueprintjs's font size for regular-sized text.

Blueprint sets a base font of 14px in components, without using relative sizes.

The root layout component currently sets the base font to 12px. It causes some issues. For example, displaying a Select in a modal makes the list appear in a portal that inherits this base size and displays it smaller than it normally would.

stropitek commented 9 months ago

TODO:

[ ] base font size to 14px in https://github.com/zakodium-oss/react-science/blob/b4f919ddc6a1df381061a825d0ff9465356d970a/src/components/root-layout/RootLayout.tsx#L21
[ ] Review all fontSize in the application
- [ ] If expressed in em unit will need to be updated to stay approximately the same font size
- [ ] If expressed in pixel, could change to em if possible
[ ] Carefully compare app and story between main branch and working branch to spot inconsistencies