zakodium-oss / react-science

React components and tools to build scientific applications.
https://react-science.pages.dev
MIT License
2 stars 6 forks source link

Use blueprintjs HTMLTable #611

Closed moonayyur closed 8 months ago

moonayyur commented 9 months ago

closes #583

cloudflare-pages[bot] commented 9 months ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ee5eecd
Status: ✅  Deploy successful!
Preview URL: https://0e0fd849.react-science.pages.dev
Branch Preview URL: https://583-use-blueprintjs-htmltabl.react-science.pages.dev

View logs

codecov-commenter commented 9 months ago

Codecov Report

Attention: 194 lines in your changes are missing coverage. Please review.

Comparison is base (fa300f8) 47.14% compared to head (ee5eecd) 24.47%. Report is 18 commits behind head on main.

Files Patch % Lines
stories/components/table.stories.tsx 0.00% 86 Missing :warning:
src/components/table/TableRow.tsx 34.83% 58 Missing :warning:
src/components/table/Table.tsx 32.43% 25 Missing :warning:
src/components/table/TableHeader.tsx 33.33% 8 Missing :warning:
src/app/panels/SignalProcessingPanel.tsx 0.00% 5 Missing :warning:
src/components/info-panel/InfoPanel.tsx 0.00% 4 Missing :warning:
stories/components/drop-zone.stories.tsx 0.00% 4 Missing :warning:
src/components/table/tableContext.ts 57.14% 3 Missing :warning:
src/app/kinds/ir/IrPeaksPanel.tsx 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #611 +/- ## =========================================== - Coverage 47.14% 24.47% -22.68% =========================================== Files 143 226 +83 Lines 7502 13025 +5523 Branches 146 234 +88 =========================================== - Hits 3537 3188 -349 - Misses 3965 9749 +5784 - Partials 0 88 +88 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

moonayyur commented 9 months ago

@stropitek an error occurs when saving the file Table.tsx (since before blueprint integration):

Error: invalid Table child at splitChildren

It disappears after refreshing the page

stropitek commented 9 months ago

@stropitek an error occurs when saving the file Table.tsx

@moonayyur what do you mean? Can you provide a link / screenshot / video to show it?

moonayyur commented 9 months ago

@moonayyur what do you mean? Can you provide a link / screenshot / video to show it?

@stropitek image

moonayyur commented 9 months ago

Is Table's color prop used anywhere? It does not seem very useful.

It is only use in StyledTable story, the text color doesn't change when modifying it using style due to the blueprint component

@moonayyur are there any other breaking changes?

I think this one is important : Replace "ValueRenderers.Title" with "ValueRenderers.Header" to make the bordered property work in the HTMLTable header