Closed moonayyur closed 8 months ago
Latest commit: |
ee5eecd
|
Status: | ✅ Deploy successful! |
Preview URL: | https://0e0fd849.react-science.pages.dev |
Branch Preview URL: | https://583-use-blueprintjs-htmltabl.react-science.pages.dev |
Attention: 194 lines
in your changes are missing coverage. Please review.
Comparison is base (
fa300f8
) 47.14% compared to head (ee5eecd
) 24.47%. Report is 18 commits behind head on main.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@stropitek an error occurs when saving the file Table.tsx (since before blueprint integration):
Error: invalid Table child at splitChildren
It disappears after refreshing the page
@stropitek an error occurs when saving the file Table.tsx
@moonayyur what do you mean? Can you provide a link / screenshot / video to show it?
@moonayyur what do you mean? Can you provide a link / screenshot / video to show it?
@stropitek
Is Table's color prop used anywhere? It does not seem very useful.
It is only use in StyledTable
story, the text color doesn't change when modifying it using style due to the blueprint component
@moonayyur are there any other breaking changes?
I think this one is important : Replace "ValueRenderers.Title" with "ValueRenderers.Header" to make the bordered property work in the HTMLTable header
closes #583
HTMLTable
headerStyledTable
Controls
story (duplicate ofControl
)