search

zakodium-oss / react-science

React components and tools to build scientific applications.
https://react-science.pages.dev
MIT License
2 stars 6 forks source link

Only keep controls that affect tooltip design #619

Closed moonayyur closed 8 months ago

moonayyur commented 8 months ago

closes #613

codecov-commenter commented 8 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c5352bc) 24.49% compared to head (7c76075) 24.50%. Report is 2 commits behind head on main.

Files Patch % Lines
stories/components/button.stories.tsx 0.00% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #619 +/- ## ========================================== + Coverage 24.49% 24.50% +0.01% ========================================== Files 223 226 +3 Lines 12964 13008 +44 Branches 234 234 ========================================== + Hits 3175 3188 +13 - Misses 9701 9732 +31 Partials 88 88 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stropitek commented 8 months ago

Can you add a similar story on a disabled button?

It's a bit of an edge case we should be able to check because disabled buttons render a different component than regular buttons (see Button implementation)

stropitek commented 8 months ago

ping @moonayyur

cloudflare-pages[bot] commented 8 months ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5c1447d
Status: ✅  Deploy successful!
Preview URL: https://acbcbb04.react-science.pages.dev
Branch Preview URL: https://613-tooltip-button-controls.react-science.pages.dev

View logs