Rewrite modal components using blueprintjss dialog

zakodium-oss / react-science

React components and tools to build scientific applications.

https://react-science.pages.dev

MIT License

2 stars 6 forks source link

Rewrite modal components using blueprintjss dialog #626

Closed wadjih-bencheikh18 closed 7 months ago

wadjih-bencheikh18 commented 8 months ago

Closes : https://github.com/zakodium-oss/react-science/issues/550 Closes: https://github.com/zakodium-oss/react-science/issues/623

cloudflare-pages[bot] commented 8 months ago

Deploying with Cloudflare Pages

Latest commit:	`2cacecb`
Status:	✅ Deploy successful!
Preview URL:	https://70ec44fc.react-science.pages.dev
Branch Preview URL:	https://550-rewrite-modal-components.react-science.pages.dev

View logs

stropitek commented 8 months ago

Can you resolve the conflicts?

stropitek commented 8 months ago

In the complex content story, please try to make the content of the Dialog content overflow. When the text overflows, only the body part should scroll and there is a prop useOverflowScrollContainer on DialogBody that should help with this.

Actually this example is a bit too specific since the part that should scroll is not the body of the modal, it's a subpart of it. But I did not understand why overflow: visible is set on the modal.

wadjih-bencheikh18 commented 8 months ago

I think it's better to use https://blueprintjs.com/docs/#core/components/dialog.multistep-dialog for complexe dialog stories

stropitek commented 8 months ago

I think it's better to use https://blueprintjs.com/docs/#core/components/dialog.multistep-dialog for complexe dialog stories

This is only for dialogs that have sequential steps, which I don't think we have anywhere and which is not the case for the general configuration dialog that NMRium has.

I think we have to try to use the generic modal to do the configuration dialog.

wadjih-bencheikh18 commented 8 months ago