zakodium-oss / react-science

React components and tools to build scientific applications.
https://react-science.pages.dev
MIT License
2 stars 6 forks source link

638 clicking outside to close the color picker is closing the modal #641

Closed wadjih-bencheikh18 closed 7 months ago

wadjih-bencheikh18 commented 7 months ago

closes : https://github.com/zakodium-oss/react-science/issues/638

cloudflare-pages[bot] commented 7 months ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0e0b213
Status: ✅  Deploy successful!
Preview URL: https://89e4442d.react-science.pages.dev
Branch Preview URL: https://638-clicking-outside-to-clos.react-science.pages.dev

View logs

codecov-commenter commented 7 months ago

Codecov Report

Attention: 52 lines in your changes are missing coverage. Please review.

Comparison is base (722bf65) 23.64% compared to head (5eca1b9) 23.51%.

Files Patch % Lines
...ories/components/color-picker-dropdown.stories.tsx 0.00% 41 Missing and 1 partial :warning:
...cker/color-picker-dropdown/ColorPickerDropdown.tsx 58.33% 10 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #641 +/- ## ========================================== - Coverage 23.64% 23.51% -0.13% ========================================== Files 221 221 Lines 12586 12607 +21 Branches 234 235 +1 ========================================== - Hits 2976 2965 -11 - Misses 9522 9553 +31 - Partials 88 89 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stropitek commented 7 months ago

Can you configure the Popover so that it does not display an arrow (blueprintjs docs show that this is possible).

The arrow and the border don't really play nice together: CleanShot 2024-01-30 at 14 05 09

wadjih-bencheikh18 commented 7 months ago

Can you configure the Popover so that it does not display an arrow (blueprintjs docs show that this is possible).

Improved