search

zakodium-oss / react-science

React components and tools to build scientific applications.
https://react-science.pages.dev
MIT License
2 stars 6 forks source link

StackedPanel component #644

Closed wadjih-bencheikh18 closed 7 months ago

wadjih-bencheikh18 commented 7 months ago

closes : https://github.com/zakodium-oss/react-science/issues/643 ref : https://github.com/zakodium-oss/react-science/issues/616 ref : https://github.com/zakodium-oss/react-science/pull/633

cloudflare-pages[bot] commented 7 months ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8ad80e3
Status: ✅  Deploy successful!
Preview URL: https://d160cbe5.react-science.pages.dev
Branch Preview URL: https://643-stackedpanel-component.react-science.pages.dev

View logs

wadjih-bencheikh18 commented 7 months ago

I's useless to have the closePanel function for the initalPanel because it works like that:

 /**
     * Call this method to programatically close this panel. If this is the only
     * panel on the stack then this method will do nothing.
     *
     * Remember that the panel header always contains a "back" button that
     * closes this panel on click (unless there is only one panel on the stack).
     */
codecov-commenter commented 7 months ago

Codecov Report

Attention: 215 lines in your changes are missing coverage. Please review.

Comparison is base (6c34c34) 23.51% compared to head (8ad80e3) 23.39%.

Files Patch % Lines
stories/components/info-panel.stories.tsx 0.00% 116 Missing and 1 partial :warning:
src/components/panels/StackedPanel.tsx 26.31% 70 Missing :warning:
src/components/toolbar/PanelPreferencesToolbar.tsx 40.00% 21 Missing :warning:
...s/components/panel-preferences-toolbar.stories.tsx 0.00% 7 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #644 +/- ## ========================================== - Coverage 23.51% 23.39% -0.13% ========================================== Files 221 222 +1 Lines 12607 12837 +230 Branches 235 235 ========================================== + Hits 2965 3003 +38 - Misses 9553 9745 +192 Partials 89 89 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stropitek commented 7 months ago

Closing because the API wasn't well thought through.

We will stick with using the blueprintjs component directly for now