search

zakodium-oss / react-science

React components and tools to build scientific applications.
https://react-science.pages.dev
MIT License
3 stars 6 forks source link

feat!: improve toolbar tip #699

Closed hamed-musallam closed 7 months ago

hamed-musallam commented 8 months ago

Screenshot 2024-03-27 at 15 51 18

hamed-musallam commented 8 months ago

Can you review this pull request? Should we rename the title property to something else, or is it acceptable to keep it as it is? Right now, it doesn't only accept a string as a value.

cloudflare-workers-and-pages[bot] commented 8 months ago

Deploying react-science with  Cloudflare Pages  Cloudflare Pages

Latest commit: 32311b0
Status: ✅  Deploy successful!
Preview URL: https://81e31ece.react-science.pages.dev
Branch Preview URL: https://improve-toolbar-tip.react-science.pages.dev

View logs

hamed-musallam commented 8 months ago

Can you review this pull request? Should we rename the title property to something else, or is it acceptable to keep it as it is? Right now, it doesn't only accept a string as a value.

What about the title property?