search

zakodium-oss / react-science

React components and tools to build scientific applications.
https://react-science.pages.dev
MIT License
3 stars 6 forks source link

Fix InfoPanel Table Row #723

Closed wadjih-bencheikh18 closed 6 months ago

wadjih-bencheikh18 commented 7 months ago

closes https://github.com/zakodium-oss/react-science/issues/721

cloudflare-workers-and-pages[bot] commented 7 months ago

Deploying react-science with  Cloudflare Pages  Cloudflare Pages

Latest commit: b7f33fa
Status: ✅  Deploy successful!
Preview URL: https://faecea3e.react-science.pages.dev
Branch Preview URL: https://721-invalid-prop-passed-to-t.react-science.pages.dev

View logs

wadjih-bencheikh18 commented 7 months ago

What's the difference between bordered and hasBorder in Table props? Maybe we can remove the context hook https://github.com/zakodium-oss/react-science/blob/287f1c3eff668e687ca5a19b04d23fd42185b6bf/src/components/table/Table.tsx#L33-L37

stropitek commented 7 months ago

I don't know. Are both used by the implementation?

wadjih-bencheikh18 commented 7 months ago

I don't know. Are both used by the implementation?

bordered is used directly by HtmlTable of blueprintjs and hasBorder is the one used in the context the two add border to the table so technically the two props do the same thing

stropitek commented 7 months ago

I think you can remove hasBorder all together and only keep the blueprintjs prop.