search

zakodium-oss / react-science

React components and tools to build scientific applications.
https://react-science.pages.dev
MIT License
3 stars 6 forks source link

feat: improve InfoPanel #727

Closed wadjih-bencheikh18 closed 5 months ago

wadjih-bencheikh18 commented 6 months ago

closes https://github.com/zakodium-oss/react-science/issues/710

cloudflare-workers-and-pages[bot] commented 6 months ago

Deploying react-science with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5f211df
Status: ✅  Deploy successful!
Preview URL: https://23fce18d.react-science.pages.dev
Branch Preview URL: https://710-do-not-scroll-behind-the.react-science.pages.dev

View logs

stropitek commented 6 months ago

@lpatiny is this ok? Seems not great that the panel does not reveal its content when opened, because it is not at the right scroll position.

https://github.com/zakodium-oss/react-science/assets/4118690/c4bad4e5-f06f-4d8e-9e55-fc5b729d29b9

targos commented 6 months ago

I think there should be only one sticky header and they should not accumulate

lpatiny commented 6 months ago

Indeed I didn't test with 2 sections and it is very confusing currently. I was not thinking that the title of the section were not scrolling but only that it does not scroll behind the search bar. On the other hand seeing in which section you are is an added value as well.

I agree with Michael that we should not accumulate the sticky header because it does not bring anything and it yields to the issue Daniel pointed out.

stropitek commented 6 months ago

I think there should be only one sticky header and they should not accumulate

I agree and I think it's good if only the search input is in the sticky header, not the section headers.