search

zakodium-oss / react-science

React components and tools to build scientific applications.
https://react-science.pages.dev
MIT License
2 stars 6 forks source link

feat: add sticky table header option #729

Closed moonayyur closed 4 months ago

moonayyur commented 4 months ago

closes #728

cloudflare-workers-and-pages[bot] commented 4 months ago

Deploying react-science with  Cloudflare Pages  Cloudflare Pages

Latest commit: ceafe35
Status: ✅  Deploy successful!
Preview URL: https://0dcfd485.react-science.pages.dev
Branch Preview URL: https://728-add-option-to-make-table.react-science.pages.dev

View logs

moonayyur commented 4 months ago

Why didn't you put the sticky option in the Header component?

Should I use cloneElement to pass the prop to Header then ?

stropitek commented 4 months ago

Should I use cloneElement to pass the prop to Header then ?

Can you explain? I don't think you need to do that in order to move the sticky prop from the Table component to the TableHeader component.