Open wadjih-bencheikh18 opened 1 month ago
Technically I prefer we update ours because recreating it with BluePrintJs is not simple.
Yes let's have our own component using the style override you made. Let's make it such that it has the exact same API as the blueprint RadioGroup component. Also let's name it differently to avoid name clashes: RadioButtonGroup
Latest commit: |
b11684f
|
Status: | ✅ Deploy successful! |
Preview URL: | https://ada0de97.react-science.pages.dev |
Branch Preview URL: | https://switch-from-radix-to-bluepri.react-science.pages.dev |
@stropitek this PR is ready
The hovered style of radio buttons is missing (vs. on the main branch)
Do your commit messages include all the breaking changes or will you provide a commit message with all the breaking changes in the PR thread?
They Include all breaking changes
The height should be 30px / 40px including the borders. It should be the same size next to a text input.
Should border-radius
also be the same?
Should
border-radius
also be the same?
No does not have to be
The content does not look centered now (it's too low), and there is a double border on the selected item.
closes : https://github.com/zakodium-oss/react-science/issues/469
For the RadioGroup component, I created the same we have with BluePrintJs Either we update ours and make it use BluePrintJs instead of radix or just remove the component because it can be done using BluePrintJs
Technically I prefer we update ours because recreating it with BluePrintJs is not simple.
https://switch-from-radix-to-bluepri.react-science.pages.dev/stories/?path=/story/forms-radio--control-button https://switch-from-radix-to-bluepri.react-science.pages.dev/stories/?path=/story/components-infopanel--basic