search

zakodium / adonis-mongodb

MongoDB provider for AdonisJS 5
https://zakodium.github.io/adonis-mongodb/
Other
63 stars 12 forks source link

feat: support @computed decorator #153

Closed tpoisseau closed 1 year ago

tpoisseau commented 1 year ago

Closes: https://github.com/zakodium/adonis-mongodb/issues/135

codecov-commenter commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
src/Model/Model.ts 98.05% <100.00%> (+0.09%) :arrow_up:
src/Model/proxyHandler.ts 100.00% <100.00%> (ø)
src/Odm/decorators.ts 100.00% <100.00%> (ø)

:loudspeaker: Thoughts on this report? Let us know!

targos commented 1 year ago

Did you try to make an API like Lucid?

tpoisseau commented 1 year ago

Yes, I try. I didn't found every places and it's hard to replicate code in two different codebase with differences. The ActiveRecord pattern is very confusing by mixing db row instances with DB API, and metadata of collection.

But, I ended to be able to make a correct @computed() getter without breaking existent tests

tpoisseau commented 1 year ago

I added support on toJSON serialization, if you see something else Lucid support with @computed you found important, Say it to me please