search

zaksabeast / CaptureSight

Tesla Overlay to view Pokemon game info in Sword, Shield, Brilliant Diamond, Shining Pearl, and Legends Arceus!
GNU General Public License v3.0
156 stars 28 forks source link

Sprite importing scripts #40

Closed ulucs closed 3 years ago

ulucs commented 4 years ago

Here are the three versions of importing scripts. I think I can write the js version with a little less abstraction, like ruby. I feel I've gone a bit overboard with abstraction in javascript. Python does not preserve key orders when reading from JSON, so an unbuggy implementation will be painful.

As it stands, I feel the best option is javascript (maybe with less abstraction).

zaksabeast commented 4 years ago

Hey, thanks! Sorry for being late to take a look at this.

I agree with JS looking like the best option, and think the abstractions make it easy to skim through and know what's going on.

zaksabeast commented 4 years ago

I see the PR is in a draft state at the moment. Let me know when you're ready for a review, and I'll get right on it :slightly_smiling_face:

zaksabeast commented 3 years ago

@ulucs I'm going to close this PR since it appears to be inactive. Please feel free to reopen it or open a new PR if you happen to come back to it. :smile: