zaksid / ext-duplicate-bookmarks-finder

Browser extension that allows to find and delete duplicate bookmarks.
MIT License
8 stars 1 forks source link

Detect suspended pages bookmarks #47

Open aluyama opened 1 year ago

aluyama commented 1 year ago

Is your feature request related to a problem? Please describe.

Detect suspended pages by marvellous suspender https://github.com/gioxx/MarvellousSuspender https://chrome.google.com/webstore/detail/noogafoofpebimajpfpamcfhoaifemoa

i think you can set to detect them easily. [chrome-extension://][anything here][uri=][duplicate URL]

E.g. this page. normal: https://github.com/zaksid/ext-duplicate-bookmarks-finder/issues/47 suspended: chrome-extension://noogafoofpebimajpfpamcfhoaifemoa/suspended.html#ttl=Detect%20suspended%20pages%20bookmarks%20%C2%B7%20Issue%20%2347%20%C2%B7%20zaksid%2Fext-duplicate-bookmarks-finder&pos=0&uri=https://github.com/zaksid/ext-duplicate-bookmarks-finder/issues/47

Additional context note: noogafoofpebimajpfpamcfhoaifemoa is the extension ID and old extension ID is klbibkeccnjlkjkiokjodocebajanakg and the new extension supports to migrate tabs but we have old bookmarks too

zaksid commented 1 year ago

Hi @aluyama , I'm not planning to add any functionality to support 3d party extensions. + Marvellous Suspender is related to tabs, not bookmarks and I don't plan to extend the extension's functionality to something beyond bookmarks management.

Thanks & Regards

aluyama commented 1 year ago

Hi @zaksid You've misunderstood this feature request. I'm not asking to add any other extensions functionality. Please follow this steps (partially or all), next you can understand this easily.

  1. Create a bookmark for this page. https://github.com/zaksid/ext-duplicate-bookmarks-finder/issues/47

  2. Go to bookmark manager and create a new folder. Next, copy the existing bookmark (ctrl+c) and paste (ctrl+v) to the new folder.

  3. Install the marvellous suspender extension and go back to the https://github.com/zaksid/ext-duplicate-bookmarks-finder/issues/47 https://chrome.google.com/webstore/detail/noogafoofpebimajpfpamcfhoaifemoa Next, Right click on this page ---> the marvellous suspender ---> Click Suspend/Unsuspend this tab image ' After that, click to create a bookmark as usual

  4. Go to your extension and search duplicates. It'll not detect 3rd bookmark as a duplicate of (1)

zaksid commented 1 year ago

Hi @aluyama, I understood the request, but the bookmark created from the suspended tab (chrome-extension://noogafoofpebimajpfpamcfhoaifemoa/suspended.html#.....) is created by a 3d party extension, this is not some native browser functionality. And both are leading to completely different places so there is no sense to consider them the same.

aluyama commented 1 year ago

I think they follow that method because there's no other better way to implement that to accomplish the goal perfectly and the suspended page URL (or the temporally URL) contains the original full URL as well chrome-extension://....=0&uri=<original URL> so you can detect them easily as i mentioned above. It also utilize a native browser functionality too. https://developer.chrome.com/blog/tab-discarding/

image

Anyway, i'm only talking about bookmark management so this'll be something like an extended/complex detection facility of duplicate file finder softwares and developers do not care about how the files have appeared, created, modified, re-organized in the disk. Just you don't need to mention about marvellous suspender in your extension. Maybe, you can re-consider this in the future or listen to some user feedbacks :)

-Thanks-