zalando-incubator / docker-locust

Docker image for the Locust.io open source load testing tool
Other
204 stars 66 forks source link

bootstrap incorrectly reports that all slaves are connected #108

Closed obergner closed 5 years ago

obergner commented 6 years ago

During bootstrap a controller node checks in app.py that the number of connected slaves is actually equal to desired number of slaves. This check, however, fails if the controller times out waiting for all slaves to come online. Instead, the controller - correctly - warns that the number of online slaves is not equal to the desired number of slaves, yet still proceeds:

5:34:47 PM INFO:bootstrap:Currently connected slaves: 0

5:34:52 PM INFO:bootstrap:Checking if all slave(s) are connected.

5:34:52 PM INFO:bootstrap:Currently connected slaves: 0

5:34:57 PM INFO:bootstrap:Checking if all slave(s) are connected.

5:34:57 PM INFO:bootstrap:Currently connected slaves: 0

5:35:02 PM WARNING:bootstrap:Connected slaves:0 != defined slaves:8

5:35:02 PM INFO:bootstrap:All slaves are succesfully connected! Start load test automatically for 150 seconds.

The issue is here: https://github.com/zalando-incubator/docker-locust/blob/1f19a41df62b5efd33214d9ad0789d35cb8dc98b/src/app.py#L107

Instead, app.py should bail out with an error.