zalando-incubator / docker-locust

Docker image for the Locust.io open source load testing tool
Other
204 stars 66 forks source link

Reintroduce python3 in the Dockerfile #94

Closed mvalkon closed 6 years ago

mvalkon commented 6 years ago

This PR reintroduces the changes made in previous PR's for moving the Dockerfile and other files to python3. The breaking changes that were discovered also seem to happen with previous images with python2. More investigation is needed.

There is no backwards compatibility for python versions here, in case such is needed a more sophisticated solution is needed.

References #80

mvalkon commented 6 years ago

@scherniavsky with these changes I can run my test case which is in python3.

codecov-io commented 6 years ago

Codecov Report

Merging #94 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #94      +/-   ##
=========================================
+ Coverage   91.79%   91.8%   +0.01%     
=========================================
  Files           7       7              
  Lines         524     525       +1     
=========================================
+ Hits          481     482       +1     
  Misses         43      43
Impacted Files Coverage Ξ”
src/app.py 87.38% <100%> (+0.05%) :arrow_up:
src/tests/test_bootstrap.py 99.13% <100%> (ΓΈ) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update cc229f5...d141b7e. Read the comment docs.

scherniavsky commented 6 years ago

:+1:

scherniavsky commented 6 years ago

:+1:

bmaher commented 6 years ago

πŸ‘

scherniavsky commented 6 years ago

:+1:

bmaher commented 6 years ago

πŸ‘

scherniavsky commented 6 years ago

:+1:

hjacobs commented 6 years ago

:+1:

mvalkon commented 6 years ago

thanks @scherniavsky @bmaher @hjacobs πŸŽ‰