zalando-incubator / kube-ingress-aws-controller

Configures AWS Load Balancers according to Kubernetes Ingress resources
MIT License
375 stars 83 forks source link

Golden file tests are blind to some parameter changes that are not ALB/NLB selection #626

Closed lucastt closed 10 months ago

lucastt commented 1 year ago

Problem statement:

Expected CF templates reference values that would be received as parameters, but the expected values are never included in the expected template, thus the expected template can be always the same as long as it respect if its a ALB or NLB template. Essentially, this would not test all other parameters except by the LB type.

For more details see https://github.com/zalando-incubator/kube-ingress-aws-controller/pull/614#issuecomment-1598304327


Possible solution:

Currently the output compared to the expected template are the ones yield by aws.generateTenplate(...). We need to also consider the input parameters set here.