Expected CF templates reference values that would be received as parameters, but the expected values are never included in the expected template, thus the expected template can be always the same as long as it respect if its a ALB or NLB template. Essentially, this would not test all other parameters except by the LB type.
Currently the output compared to the expected template are the ones yield by aws.generateTenplate(...). We need to also consider the input parameters set here.
Problem statement:
Expected CF templates reference values that would be received as parameters, but the expected values are never included in the expected template, thus the expected template can be always the same as long as it respect if its a ALB or NLB template. Essentially, this would not test all other parameters except by the LB type.
For more details see https://github.com/zalando-incubator/kube-ingress-aws-controller/pull/614#issuecomment-1598304327
Possible solution:
Currently the output compared to the expected template are the ones yield by
aws.generateTenplate(...)
. We need to also consider the input parameters set here.