search

zalando-incubator / kube-ingress-aws-controller

Configures AWS Load Balancers according to Kubernetes Ingress resources
MIT License
375 stars 83 forks source link

Make Resource conversion tests also check params and tags #649

Closed lucastt closed 10 months ago

lucastt commented 10 months ago

This changes should fix the current behavior of golden file tests that do not really check important parameters and only check the correctness of the template, which is not really testing the stack generation algorithm of the ingress controller.

https://github.com/zalando-incubator/kube-ingress-aws-controller/issues/626

lucastt commented 10 months ago

👍

AlexanderYastrebov commented 10 months ago

:+1:

AlexanderYastrebov commented 10 months ago

Marked as do-not-merge until we decide if we merge to master or a feature branch

szuecs commented 10 months ago

:+1:

szuecs commented 10 months ago

@AlexanderYastrebov I think in this case there is only test changed, so no production code path can change so we can also merge it to master IMO.