search

zalando-incubator / kube-ingress-aws-controller

Configures AWS Load Balancers according to Kubernetes Ingress resources
MIT License
375 stars 83 forks source link

Add option to filter certificates by tag before adding it to LB #658

Closed lucastt closed 10 months ago

lucastt commented 10 months ago

This feature aims to enable kube-ingress-aws-controller to ignore certificates based on tags. Effectively what this means is, you can specify a tag through the command line and the ingress controller will only use IAM/ACM certificates that have that specific tag when matching the host to define which certificate is more appropriate to add to the LB.

If a tag is not specified the ingress controller shall pick all available certificates for matching.

The main idea behind this feature is to make it very specific which certificates should be considered, this feature does not avoid incidents, but make it clearer to operators which certificates are being considered in the matching phase.

This PR addresses the issue: https://github.com/zalando-incubator/kube-ingress-aws-controller/issues/652

lucastt commented 10 months ago

👍

szuecs commented 10 months ago

lgtm

lucastt commented 10 months ago

👍

lucastt commented 10 months ago

👍

szuecs commented 10 months ago

:+1: