search

zalando-incubator / kube-ingress-aws-controller

Configures AWS Load Balancers according to Kubernetes Ingress resources
MIT License
375 stars 83 forks source link

Set the default ingress API Version #679

Closed jhuntwork closed 5 months ago

jhuntwork commented 5 months ago

Fixes #678

With the removal of the --ingress-api-version flag in 0.15.0, this value was no longer set and the constructed api URL is incomplete.

mikkeloscar commented 5 months ago

Thanks, I agree this is a quick mitigation to the issue introduced. Probably it makes sense to not pass it to the adapter at all but just use the constant value inside the adapter.

mikkeloscar commented 5 months ago

:+1:

katyanna commented 5 months ago

👍

jhuntwork commented 5 months ago

Thanks for the quick review and merge!