zalando-incubator / kubernetes-on-aws

Deploying Kubernetes on AWS with CloudFormation and Ubuntu
https://kubernetes-on-aws.readthedocs.io/
MIT License
624 stars 163 forks source link

skipper: disable image-updater-bot for main image #8216

Closed AlexanderYastrebov closed 1 week ago

AlexanderYastrebov commented 1 week ago

image-updater-bot replaces all matching image urls in the manifest so use print template function to disable it for main image.

Follow up #8193

AlexanderYastrebov commented 1 week ago

image-updater-bot replaces all matching image urls in the manifest so use print template function to disable it for main image.

See example https://github.com/zalando-incubator/kubernetes-on-aws/pull/8205

AlexanderYastrebov commented 1 week ago

image-updater-bot replaces all matching image urls in the manifest so use print template function to disable it for main image.

Here is an example when it worked properly because main image url was different from canary https://github.com/zalando-incubator/kubernetes-on-aws/pull/8220/commits/71a794b8bb7ca2e08a00b7680bcfe9a231aecbea

RomanZavodskikh commented 1 week ago

https://github.com/zalando-incubator/kubernetes-on-aws/pull/8220/files advances only canary image, so I guess we can move on like this and find some way to make the description of it more informative.

RomanZavodskikh commented 1 week ago

:+1:

AlexanderYastrebov commented 1 week ago

:+1: