search

zalando-incubator / spark-json-schema

JSON schema parser for Apache Spark
MIT License
81 stars 43 forks source link

made 'id' and 'name' optional as per IETF spec #19

Closed developmentalmadness closed 7 years ago

developmentalmadness commented 7 years ago

Id and name are optional fields according to the IETF spec. This change allows them to be optional.

codecov-io commented 7 years ago

Codecov Report

Merging #19 into master will not change coverage. The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #19   +/-   ##
=======================================
  Coverage   91.11%   91.11%           
=======================================
  Files           1        1           
  Lines          45       45           
  Branches        2        2           
=======================================
  Hits           41       41           
  Misses          4        4
Impacted Files Coverage Δ
...org/zalando/spark/jsonschema/SchemaConverter.scala 91.11% <100%> (ø) :white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c5702af...e227e43. Read the comment docs.

hesserp commented 7 years ago

:+1:

tammok commented 7 years ago

:+1: