zalando-incubator / spark-json-schema

JSON schema parser for Apache Spark
MIT License
81 stars 43 forks source link

Feature/codacy complaints #32

Closed hesserp closed 7 years ago

hesserp commented 7 years ago

remove null, remove unnamed results, remove unconventional variable names

codecov-io commented 7 years ago

Codecov Report

Merging #32 into master will decrease coverage by 1.2%. The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
- Coverage   92.77%   91.56%   -1.21%     
==========================================
  Files           1        1              
  Lines          83       83              
  Branches        1        1              
==========================================
- Hits           77       76       -1     
- Misses          6        7       +1
Impacted Files Coverage Δ
...org/zalando/spark/jsonschema/SchemaConverter.scala 91.56% <83.33%> (-1.21%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6b58f64...3dab374. Read the comment docs.

pabair commented 7 years ago

👍

hesserp commented 7 years ago

:+1: