Switch to a newer version of Kubernetes API for Ingresses and Deployments

tortila commented 5 years ago

Switch to a newer version of Kubernetes API for Ingresses and Deployments. The API extensions/v1beta1 no longer contains Deployment definitions. I switched the Ingress definitions to use networking.k8s.io/v1beta1 just in case, but also because this is the version used in the official examples. EDIT: Now I can actually see that this is a planned deprecation - Ingress definition will be removed from extensions/v1beta1 in Kubernetes version v1.20.

Additionally this PR:

adds memory limits to all containers used in the example manifests,
adds black as a dev dependency.

Closes #20.

Types of Changes

What types of changes does your code introduce? Keep the ones that apply:

Bug fix (non-breaking change which fixes an issue)
Refactor/improvements

Review

Reviewers' checklist:

If this PR implements new flows or changes existing ones, are there good tests for these flows? If this PR rather removes flows, are the obsolete tests removed as well?
Is the documentation still up-to-date and exhaustive? This covers both technical (in source files) and functional (under docs/) documentation.
Is the changelog updated?
Does the new version number correspond to the actual changes from this PR? In doubt, refer to https://semver.org.

Additional notes

I tested the changes with the example manifests (both combined and distributed modes) in a real Kubernetes cluster, ~but didn't have a chance to test it with local cluster spawned by minikube, because I couldn't make minikube work on my MacBook 😢~ works on minikube too.

zincr[bot] commented 5 years ago

🤖 zincr found 0 problems , 1 warning

ℹ️ Large Commits
✅ Approvals
✅ Specification
✅ Dependency Licensing

Details on how to resolve are provided below

Large Commits

Checks all commits for large additions to a single file. Large commits should be reviewed more carefully for potential copyright and licensing issues

This file contains a substantial change, please review to determine if the change comes from an external source and if there are any copyright or licensing issues to be aware of

ℹ️ poetry.lock had +100 lines of code changed in a single commit Please review this file to determine the source of this change

tortila commented 5 years ago

@perploug do you know what happened to the DCO integration? It looks like it was switched off. If it was on purpose, we should also stop depending on the required status check from DCO.

bmaher commented 5 years ago

@tortila I'll try to check it on minikube

tortila commented 5 years ago

@bmaher I got some help with testing this PR on minikube within Zalando, and everything works as expected. I will merge this PR once I figure out the deal with the DCO bot

zalando-incubator / zelt