zalando-incubator / zelt

A command-line tool for orchestrating the deployment of Locust in Kubernetes.
https://zelt.readthedocs.io
MIT License
36 stars 3 forks source link

Support K8s custom resources #23

Closed tortila closed 4 years ago

tortila commented 4 years ago

Add support for custom resources.

Closes #22

Description

Rationale for this feature can be found in the corresponding issue: #22.

Some decisions that I made along the way:

Additionally, as mentioned in the issue: fetching of the available custom resources in the cluster is not a convenience feature, but rather a prerequisite. Call to create a custom resource demands a plural which can only be found on the custom resource definition (and not in the manifest).

Types of Changes

Review

Reviewers' checklist:

zincr[bot] commented 4 years ago

🤖 zincr found 0 problems , 1 warning

ℹ️ Large Commits
✅ Approvals
✅ Specification
✅ Dependency Licensing

Details on how to resolve are provided below


Large Commits

Checks all commits for large additions to a single file. Large commits should be reviewed more carefully for potential copyright and licensing issues

This file contains a substantial change, please review to determine if the change comes from an external source and if there are any copyright or licensing issues to be aware of

tortila commented 4 years ago

I will merge with the Codacy warning, as it concerns pytest specific functions and is only for tests.