Closed tortila closed 4 years ago
ℹ️ Large Commits
✅ Approvals
✅ Specification
✅ Dependency Licensing
Details on how to resolve are provided below
Checks all commits for large additions to a single file. Large commits should be reviewed more carefully for potential copyright and licensing issues
This file contains a substantial change, please review to determine if the change comes from an external source and if there are any copyright or licensing issues to be aware of
I will merge with the Codacy warning, as it concerns pytest specific functions and is only for tests.
Add support for custom resources.
Closes #22
Description
Rationale for this feature can be found in the corresponding issue: #22.
Some decisions that I made along the way:
Manifest
's propertykind
is of typeResourceType
, which is anEnum
. I decided not to extend thisEnum
and not to change the type of this property. Instead, the custom manifests that are found will havekind
of equal toResourceType.OTHER
, which has a meaningless value of...
. In order to get the realkind
of the resource as defined in the custom manifest, its property.body["kind"]
needs to be looked up instead.scope
equal toCluster
) will be ignored.Additionally, as mentioned in the issue: fetching of the available custom resources in the cluster is not a convenience feature, but rather a prerequisite. Call to create a custom resource demands a
plural
which can only be found on the custom resource definition (and not in the manifest).Types of Changes
Review
Reviewers' checklist:
docs/
) documentation.