Closed NeolithEra closed 4 years ago
Hi @NeolithEra! It looks like kubernetes
always used pyyaml>=3.12
(e.g. in v10.0.1 or v11.0.0 or master), except for v10.1.0 where they used pyyaml~=3.12
for some reason. That's clearly not a "non breaking change" according to semver, but :man_shrugging:
In my opinion the simplest fix on our side is to update our bounds on kubernetes
:
@@ -23,7 +23,7 @@ packages = [{include = "zelt"}, { include = "main.py"}]
[tool.poetry.dependencies]
python = "^3.6"
har-transformer = "^1.0"
-kubernetes = "^10.0.1"
+kubernetes = "^11.0.0"
locustio = "^0.9.0"
boto3 = "^1.9"
greenlet = "^0.4.15"
You're of course welcome to propose a pull request, otherwise without any other opinion I'll go ahead and make the update myself this evening. What do you think?
Interesting to see that the reason for this change in v10.1.0 was that pyyaml stopped supporting Python 3.4: https://github.com/kubernetes-client/python/pull/1079#issuecomment-589816780. Kubernetes client also drops that support in v11.0.0a1
Hi, users are unable to run Zelt due to dependency conflict with pyyaml package. As shown in the following full dependency graph of Zelt, Zelt requires pyyaml>=5.1,<6.0,while kubernetes>=10.0.1,<11.0.0 requires pyyaml~=3.12.
According to pip’s “first found wins” installation strategy, pyyaml 5.3.1 is the actually installed version. However, pyyaml 5.3.1 does not satisfy pyyaml~=3.12.
Dependency tree-----------
Thanks for your help. Best, Neolith