zalando-incubator / zelt

A command-line tool for orchestrating the deployment of Locust in Kubernetes.
https://zelt.readthedocs.io
MIT License
36 stars 3 forks source link

Fix kubernetes dependency conflict #25

Closed thilp closed 4 years ago

thilp commented 4 years ago

Exclude the problematic version 10.1.0 of our kubernetes dependency.

Closes #24.

Description

That version (the only one released between 10.0.1 and 11) changes its dependency on pyyaml from >=3.2 to ~=3.2, which is much more restrictive since it translates to >=3.2 <3.3. The >=3.2 constraint was restored in versions 11+.

Also relax the constraint on black, which is just a development dependency.

Types of Changes

Review

Reviewers' checklist:

zincr[bot] commented 4 years ago

🤖 zincr found 0 problems , 1 warning

ℹ️ Large Commits
✅ Approvals
✅ Specification
✅ Dependency Licensing

Details on how to resolve are provided below


Large Commits

Checks all commits for large additions to a single file. Large commits should be reviewed more carefully for potential copyright and licensing issues

This file contains a substantial change, please review to determine if the change comes from an external source and if there are any copyright or licensing issues to be aware of

thilp commented 4 years ago

I only ran the unit tests and they were fine, but I didn't check further (I don't use Zelt at work these days). For that reason, I decided it would be wiser to refrain from upgrading to kubernetes v11 without an actual need from our users; end-to-end tests for Zelt are a bit of work :smile: