Closed thilp closed 4 years ago
ℹ️ Large Commits
✅ Approvals
✅ Specification
✅ Dependency Licensing
Details on how to resolve are provided below
Checks all commits for large additions to a single file. Large commits should be reviewed more carefully for potential copyright and licensing issues
This file contains a substantial change, please review to determine if the change comes from an external source and if there are any copyright or licensing issues to be aware of
I only ran the unit tests and they were fine, but I didn't check further (I don't use Zelt at work these days). For that reason, I decided it would be wiser to refrain from upgrading to kubernetes
v11 without an actual need from our users; end-to-end tests for Zelt are a bit of work :smile:
Exclude the problematic version 10.1.0 of our
kubernetes
dependency.Closes #24.
Description
That version (the only one released between 10.0.1 and 11) changes its dependency on pyyaml from
>=3.2
to~=3.2
, which is much more restrictive since it translates to>=3.2 <3.3
. The>=3.2
constraint was restored in versions 11+.Also relax the constraint on black, which is just a development dependency.
Types of Changes
Review
Reviewers' checklist:
docs/
) documentation.