search

zalando-nakadi / kanadi

Kanadi is a Nakadi client for Scala
MIT License
29 stars 19 forks source link

modifySourceFunction is not used in Subscriptions.eventsStreamedManaged #70

Closed gamsd closed 5 years ago

gamsd commented 5 years ago

In Subscriptions.eventsStreamedManaged(), the modifySourceFunction parameter is not passed along to the underlying Subscriptions.eventsStreamed() call. That means it's never called and the source never modified.

gamsd commented 5 years ago

@mdedetrich Fix is a one-liner, but testing is way more involved. Is this the kind of thing that you would consider merging without tests?

mdedetrich commented 5 years ago

@gamsd It shouldn't be too hard to test, you can supply a modifySourceFunction that just returns itself while setting an AtomicBoolean and then check that the AtomicBoolean is true.

I can also set up a PR to do this, shouldn't be too hard