zalando-nakadi / nakadi-producer-spring-boot-starter

Nakadi event producer as a Spring boot starter
MIT License
13 stars 8 forks source link

Bugfix: no stups token bean if not needed #176

Closed ePaul closed 1 year ago

ePaul commented 1 year ago

When the application already supplies a NakadiPublishingClient or NakadiClient bean, we don't need our own authentication setup.

This was already meant to be skipped, but I guess we misunderstood how nested configuration classes work – they don't inherit their outer classes' conditions.

As an effect, even when one of these beans is already there, a new StupsTokenComponent bean was created (and the build failed if that was not possible e.g. due to missing configuration variables).

ePaul commented 1 year ago

:+1:

fbrns commented 1 year ago

👍