#191: add main logic for EidGeneratorStrategy

zalando-nakadi / nakadi-producer-spring-boot-starter

Nakadi event producer as a Spring boot starter

MIT License

13 stars 8 forks source link

#191: add main logic for EidGeneratorStrategy #192

Open Chuburashka opened 4 months ago

Chuburashka commented 4 months ago

This is an approach for solving #191.

add a database column eid.
this gets by default filled with the same value as the id column (converted to UUID just as the current Java code is doing it)
An EidGeneratorStrategy can be injected to generate this eid value in a different way (e.g. randomly).
When sending events, the eid value is used for the events.

Chuburashka commented 3 months ago

@ePaul I removed function from INSERT query in the last commit.

Also I reverted this changes for EventLog.getEid() method.

Because I think if we decided to leave eid field null by default better to leave it null and client side should decide what to do with this field. And we do it in the same place as before in EventTransmissionService

ePaul commented 3 months ago

I deployed a release-candidate version (21.1.0-RC-eidgenerator) to our internal Nexus.

Feel free to try this out in your projects.

There are some merge conflicts with some of the other open PRs, so I couldn't easily create a release candidate containing the changes for all of them.

ePaul commented 2 months ago

:+1:

ePaul commented 2 months ago

:+1:

Chuburashka commented 8 hours ago

👍