zalando-nakadi / nakadi-producer-spring-boot-starter

Nakadi event producer as a Spring boot starter
MIT License
13 stars 8 forks source link

Spring Boot 2 support for snapshot creation #81

Closed goekhanak closed 6 years ago

goekhanak commented 6 years ago

Currently, it's not easy to use nakadi-producer-spring-boot-starter with Spring Boot 2, because the actuator endpoints support has been significantly reworked.

The impact is that we can't upgrade our services to Spring Boot 2 if they are using the Nakadi Producer library and vice versa: we can't use the library in the services running on Spring Boot 2 (currently none).

Here is a guide on how to migrate: https://github.com/spring-projects/spring-boot/wiki/Migrating-a-custom-Actuator-endpoint-to-Spring-Boot-2 Here's a guide on how to write them from scratch: http://www.baeldung.com/spring-boot-actuators#boot-2x-actuator

ePaul commented 6 years ago

Sounds like a good idea, thanks for the proposal.

If you work on this, please make sure that this doesn't introduce a must-have dependency on Spring Boot 2, i.e. that it still works with earlier Spring Boot.