search

zalando-stups / docker-node

DEPRECATED: Docker image with Node.js and Zalando CA
8 stars 9 forks source link

Bump versions to recent ones #25

Closed kgalli closed 7 years ago

kgalli commented 7 years ago

This PR bump all versions (ancient, stable and lts) to the most recent ones. Due to the fact that version 6 is not LTS and version 4 as well I did not change anything in regard to stable and lts.

kgalli commented 7 years ago

@prayerslayer right now I'm not able to build those dockerfiles by myself due to the fact that ha.pool.sks-keyservers.net seems to be down or something. But maybe it is just my machine. So this info is just if you see the same issue.

prayerslayer commented 7 years ago

Shouldn't v6 be LTS by now? https://github.com/nodejs/LTS#lts-schedule

ha.pool.sks-keyservers.net

Related to this maybe? I don't know.

kgalli commented 7 years ago

You are right v6 is LTS now. But when you look at https://nodejs.org/en/ you can see v4 and v6 are considered LTS for the moment. So my suggestion is we keep our structure for now because there is no v7 stable or something.

kgalli commented 7 years ago

Building node works now by the way. So you might be the DOS attack you linked.

kgalli commented 7 years ago

@prayerslayer are you going to merge this PR or do you want me to change something?

prayerslayer commented 7 years ago

Will merge.