search

zalando-stups / docker-node

DEPRECATED: Docker image with Node.js and Zalando CA
8 stars 9 forks source link

Upgrade version: npm@5 #34

Closed shuhei closed 7 years ago

shuhei commented 7 years ago

Upgrading npm of stable. Leaving lts as is because Node.js LTS doc says LTS is limited to "Non-semver-major npm updates".

Also, changing npm cache clear (alias of npm cache clean) to npm cache clean --force because now the command requires --force. https://docs.npmjs.com/cli/cache#details

Fixes #33

harti2006 commented 7 years ago

:+1:

hjacobs commented 7 years ago

Let's do #35 before we merge anything and release a new image :smile:

harti2006 commented 7 years ago

@shuhei what about updating nodejs to the latest stable version (8.1.2) as well?

shuhei commented 7 years ago

@harti2006 If you are OK with it, I'm OK too. I just wanted to use npm 5's package-lock.json.

kgalli commented 7 years ago

@shuhei please update to the most recent version of NPM (currently 5.1.0) and I can merge the change.

@harti2006 from my point of view we can switch to 8.1.3 because it is the stable node version now. Please create a PR and it can be merged as well.

harti2006 commented 7 years ago

:+1:

kgalli commented 7 years ago

👍

kgalli commented 7 years ago

@harti2006 What do you think about using yarn and follow the official docker node repo?

harti2006 commented 7 years ago

@kgalli I don't have experience with yarn. we are using our own docker base images, based on ubuntu, because they include the Zalando cert authority. Teams are not require to use it, but could instead use official docker node images as a base for their docker images.

shuhei commented 7 years ago

@harti2006 Thanks for updating the version :-)