search

zalando-stups / docker-node

DEPRECATED: Docker image with Node.js and Zalando CA
8 stars 9 forks source link

Update node version to 0.12.9 #8

Closed kgalli closed 8 years ago

kgalli commented 8 years ago

This change also replaces Henning as a maintainer with Zalando SE.

kgalli commented 8 years ago

@prayerslayer can you have a look at this and merge it. I would really like to update our docker node image asap.

prayerslayer commented 8 years ago

Let's see if I get to set up a vagrantbox or something today :+1:

kgalli commented 8 years ago

:+1:

kgalli commented 8 years ago

@prayerslayer any updates?

prayerslayer commented 8 years ago

On it now.

prayerslayer commented 8 years ago

Looks good otherwise. :+1: Unfortunately I can't build this today.

kgalli commented 8 years ago

@prayerslayer right now we take the snippet for the RUN command from the official node repository. The sha256sum command is available on debian and ubuntu systems. Our base image is an ubuntu base image. So I would like not to switch to shasum. I'm still wondering why you have trouble with this because the command is executed against your base image (which is ubuntu).

prayerslayer commented 8 years ago

Hm, just tried again and it worked fine, no idea what went wrong last year. I have no objections anymore :)

I will merge your PRs and also update the Ubuntu base image. Images will be available maybe throughout the day, but definitely tomorrow.

Thanks for your patience.

kgalli commented 8 years ago

:+1:

prayerslayer commented 8 years ago

...as soon as I can actually merge PRs here :grin:

kgalli commented 8 years ago

Yes, two maintainers both lacking the right to merge PRs might be an issue ;-) ...

prayerslayer commented 8 years ago

Maybe @hjacobs can edit the permissions, as he created the repo?

kgalli commented 8 years ago

ping @hjacobs ...