Fixed handling of --all flag in list-violations.

zalando-stups / fullstop-cli

Simple command line utility to view and resolve fullstop. violations

https://pypi.python.org/pypi/stups-fullstop/

Other

3 stars 5 forks source link

Fixed handling of --all flag in list-violations. #14

Closed tkrop closed 8 years ago

tkrop commented 8 years ago

It seems that the fullstop service has changed its default behavior from providing all violations to providing only violations that are not resolved. Therefore the original content filter does not work any longer. Instead it is now necessary to make a second request to the fullstop server to request resolved violations using the query parameter "checked=true".

hjacobs commented 8 years ago

@tkrop probably some of the Fullstop maintainers (@prayerslayer @harti2006 ) can check why and how the API changed?

prayerslayer commented 8 years ago

Apparently this was the issue in question: https://github.com/zalando-stups/fullstop/issues/378

And yes, by default only unresolved violations are returned.

hjacobs commented 8 years ago

:+1: