zalando-stups / fullstop-cli

Simple command line utility to view and resolve fullstop. violations
https://pypi.python.org/pypi/stups-fullstop/
Other
3 stars 5 forks source link

#24 filter by application / version #26

Closed harti2006 closed 8 years ago

harti2006 commented 8 years ago

fixes #24

hjacobs commented 8 years ago

I still see "application_version: 123" in the meta info column as you only remove "application_version_id" --- is this some mismatch/migration/typo?

harti2006 commented 8 years ago

Fixed. it should be application_version. Sadly Fullstop is not so consistent in the naming of query-params, and response properties

hjacobs commented 8 years ago

application-ids and application-version-ids are plural, but the option values are single strings --- what is the expected format? Is it a comma separated string of IDs?

harti2006 commented 8 years ago

Fullstop API can handle comma-separated strings as well as multi values ?application-ids=foo&application-ids=bar. I did it the same way as the --accounts are currently handled

hjacobs commented 8 years ago

:+1:

harti2006 commented 8 years ago

:+1: