search

zalando-stups / fullstop-cli

Simple command line utility to view and resolve fullstop. violations
https://pypi.python.org/pypi/stups-fullstop/
Other
3 stars 5 forks source link

--limit N option might return less than N results #5

Open dryewo opened 8 years ago

dryewo commented 8 years ago 
$ fullstop list-violations -m -l 3

gives only 2 rows

hjacobs commented 8 years ago

Works in general, but it will not work as expected if some client-side filtering is used (e.g. "-m") as the limit is passed to the server REST API.

sezeryilmaz commented 8 years ago

It would be really helpful if we could consider the paging of the fullstop api and incorporate this also somehow into the cli. Maybe an optional flag --all, just iterate and show everything if it doesn't result in a performance issue.