search

zalando-stups / hutmann

Simple OAuth2 for Play! backend services
Other
3 stars 6 forks source link

Migration to Play 2.7 #22

Closed mtrushin closed 5 years ago

mtrushin commented 5 years ago

Migration to Play 2.7.0

mtrushin commented 5 years ago

👍

ovolynets commented 5 years ago

@mtrushin thanks for the pull request. I put one minor comment but otherwise the changes look good from my side. Would be also nice to have a review from someone who is familiar with Play 2.7 to have a look.

mtrushin commented 5 years ago

thanks @ovolynets for the review! I'm afraid it is not easy to find developers familiar with Play 2.7 because it was released only 12 days ago, here is the Migration Guide: https://www.playframework.com/documentation/2.7.x/Migration27

ovolynets commented 5 years ago

@mtrushin I'm happy to merge and publish (if I still can). Did you try to integrate these changes to one of your services?

ovolynets commented 5 years ago

Ah, no, maybe I can't. @musiKk do you have access to publishing?

mtrushin commented 5 years ago

@ovolynets yes, new version is already integrated with one of our services which we want to migrate to Play 2.7, waiting for review now...

ovolynets commented 5 years ago

👍

ovolynets commented 5 years ago

@mtrushin ok, thanks for clarifying. I'd wait for the admin's approval (@musiKk are you available?).

musiKk commented 5 years ago

I'll see if I find time to look into this on Monday. Spoiler alert, I'm definitely not familiar with 2.7. We're still running on 2.5 and will migrate to 2.6 shortly.

musiKk commented 5 years ago

:+1: