search

zalando-stups / kio

The application registry in the STUPS ecosystem
http://docs.stups.io/en/latest/components/kio.html
Other
23 stars 11 forks source link

Add a `support_url` field to application schema #125

Closed GoWind closed 4 years ago

GoWind commented 4 years ago

Add a support_url field to the application schema that can be used to contact the team maintaining the application for filing feature/bug/support requests. This is different from the 24x7 contact field, which is used for contacting about incidents and downtime The issue is documented here

tkrop commented 4 years ago

:+1:

tkrop commented 4 years ago

No further code or way to test these addition?

GoWind commented 4 years ago

No further code or way to test these addition? Let me see if I can add a test, but so far I think the tests are good enough.

hjacobs commented 4 years ago

Let's ask @thilp for a review. See my comments, otherwise looks OK.

GoWind commented 4 years ago

@hjacobs I have updated the PR with the changes suggested (removed extra space and default '') . Can you take a look at it and approve/reject/suggest changes ?

hjacobs commented 4 years ago

:+1:

thilp commented 4 years ago

:+1: